Re: tg3 driver not advertising 1000mbit

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Matt Carlson
Date: Thursday, July 2, 2009 - 9:42 am

On Tue, Jun 30, 2009 at 02:20:45AM -0700, Jean-Louis Dupond wrote:

Rats.  I mirrored your setup here, but I still can't reproduce the
problem.  I still suspect this is a bad driver <=> firmware interaction.

Can you apply the following patch and show me the resulting syslog
entries?  The patch is just making sure the firmware request to shutdown
really goes through.


diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
index 46a3f86..900e28b 100644
--- a/drivers/net/tg3.c
+++ b/drivers/net/tg3.c
@@ -1124,6 +1124,9 @@ static void tg3_wait_for_event_ack(struct tg3 *tp)
 			break;
 		udelay(8);
 	}
+
+	if (i == delay_cnt)
+		printk( KERN_WARNING "Firmware didn't ack driver event!\n" );
 }
 
 /* tp->lock is held. */
@@ -6330,12 +6333,16 @@ static void tg3_stop_fw(struct tg3 *tp)
 		/* Wait for RX cpu to ACK the previous event. */
 		tg3_wait_for_event_ack(tp);
 
+		printk( KERN_NOTICE "%s: Stopping firmware.\n", tp->dev->name );
+
 		tg3_write_mem(tp, NIC_SRAM_FW_CMD_MBOX, FWCMD_NICDRV_PAUSE_FW);
 
 		tg3_generate_fw_event(tp);
 
 		/* Wait for RX cpu to ACK this event. */
 		tg3_wait_for_event_ack(tp);
+
+		printk( KERN_NOTICE "%s: Operation completed.\n", tp->dev->name );
 	}
 }
 
@@ -7537,6 +7544,8 @@ static void tg3_timer(unsigned long __opaque)
 		    !(tp->tg3_flags3 & TG3_FLG3_ENABLE_APE)) {
 			tg3_wait_for_event_ack(tp);
 
+			printk( KERN_NOTICE "%s: Sending keepalive event.\n", tp->dev->name );
+
 			tg3_write_mem(tp, NIC_SRAM_FW_CMD_MBOX,
 				      FWCMD_NICDRV_ALIVE3);
 			tg3_write_mem(tp, NIC_SRAM_FW_CMD_LEN_MBOX, 4);

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
tg3 driver not advertising 1000mbit, Jean-Louis Dupond, (Fri Jun 12, 7:05 am)
Re: tg3 driver not advertising 1000mbit, Michael Chan, (Fri Jun 12, 11:37 am)
Re: tg3 driver not advertising 1000mbit, Jean-Louis Dupond, (Fri Jun 12, 2:51 pm)
Re: tg3 driver not advertising 1000mbit, Michael Chan, (Fri Jun 12, 3:01 pm)
Re: tg3 driver not advertising 1000mbit, Jean-Louis Dupond, (Fri Jun 12, 3:16 pm)
Re: tg3 driver not advertising 1000mbit, Michael Chan, (Fri Jun 12, 6:31 pm)
Re: tg3 driver not advertising 1000mbit, Matt Carlson, (Wed Jun 24, 10:36 am)
Re: tg3 driver not advertising 1000mbit, Jean-Louis Dupond, (Fri Jun 26, 2:33 pm)
Re: tg3 driver not advertising 1000mbit, Matt Carlson, (Fri Jun 26, 7:26 pm)
Re: tg3 driver not advertising 1000mbit, Jean-Louis Dupond, (Sat Jun 27, 2:58 am)
Re: tg3 driver not advertising 1000mbit, Matt Carlson, (Mon Jun 29, 11:50 am)
Re: tg3 driver not advertising 1000mbit, Jean-Louis Dupond, (Tue Jun 30, 2:20 am)
Re: tg3 driver not advertising 1000mbit, Matt Carlson, (Thu Jul 2, 9:42 am)
Re: tg3 driver not advertising 1000mbit, Krzysztof Olędzki, (Wed Nov 24, 1:09 pm)
Re: tg3 driver not advertising 1000mbit, Jean-Louis Dupond, (Wed Nov 24, 3:27 pm)