Re: [GIT PULL] time.c - respin

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Ingo Molnar
Date: Thursday, August 21, 2008 - 3:22 am

* Glauber Costa <gcosta@redhat.com> wrote:


i've tried it, and -tip testing found a hang on 64-bit x86.

It hangs here:

[    0.340029] calling  tc_filter_init+0x0/0x4c
[    0.340029] initcall tc_filter_init+0x0/0x4c returned 0 after 0 msecs
[    0.340029] calling  genl_init+0x0/0xd8
[ hard hang ]

it should have continued with:

[    2.976346] initcall genl_init+0x0/0xd8 returned 0 after 15 msecs
[    2.982303] calling  cipso_v4_init+0x0/0x88
[ ... etc ... ]

i've bisected the hang back to:

0de577d0dd2d1101431d3438d0880fa32a6188d6 is first bad commit
commit 0de577d0dd2d1101431d3438d0880fa32a6188d6
Author: Glauber Costa <gcosta@redhat.com>
Date:   Fri Jul 11 15:43:19 2008 -0300

    x86: use generic intr_init call

    Replace apic initialization code with generic intr_init_hook().

    Signed-off-by: Glauber Costa <gcosta@redhat.com>

the config is at:

 http://redhat.com/~mingo/misc/config-Thu_Aug_21_11_14_36_CEST_2008.bad

but the bug is rather obvious:

-       apic_intr_init();
-
-       if (!acpi_ioapic)
-               setup_irq(2, &irq2);
+       intr_init_hook();

why exactly did you remove the cascade IRQ registration? If it remains 
unallocated and a driver happens to use it funny things might occur.

Also, the commit log does not declare why it's removed.

	Ingo
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[GIT PULL] time.c - respin, Glauber Costa, (Wed Aug 20, 8:07 am)
Re: [GIT PULL] time.c - respin, Ingo Molnar, (Thu Aug 21, 3:22 am)
Re: [GIT PULL] time.c - respin, Glauber Costa, (Thu Aug 21, 6:07 am)
Re: [GIT PULL] time.c - respin, Ingo Molnar, (Sun Aug 24, 5:31 am)
Re: [GIT PULL] time.c - respin, Ingo Molnar, (Sun Aug 24, 6:16 am)
Re: [GIT PULL] time.c - respin, Ingo Molnar, (Sun Aug 24, 6:39 am)