Re: 2.6.25-rc2 regression in rt61pci wireless driver

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Ivo van Doorn
Date: Tuesday, February 19, 2008 - 2:26 am

Hi,


Thanks. I think I found something, please test below patch:

---
diff --git a/drivers/net/wireless/rt2x00/rt2x00dev.c b/drivers/net/wireless/rt2x00/rt2x00dev.c
index 015738a..8df1991 100644
--- a/drivers/net/wireless/rt2x00/rt2x00dev.c
+++ b/drivers/net/wireless/rt2x00/rt2x00dev.c
@@ -249,10 +249,10 @@ static void rt2x00lib_evaluate_antenna(struct rt2x00_dev *rt2x00dev)
 	rt2x00dev->link.ant.flags &= ~ANTENNA_TX_DIVERSITY;
 
 	if (rt2x00dev->hw->conf.antenna_sel_rx == 0 &&
-	    rt2x00dev->default_ant.rx != ANTENNA_SW_DIVERSITY)
+	    rt2x00dev->default_ant.rx == ANTENNA_SW_DIVERSITY)
 		rt2x00dev->link.ant.flags |= ANTENNA_RX_DIVERSITY;
 	if (rt2x00dev->hw->conf.antenna_sel_tx == 0 &&
-	    rt2x00dev->default_ant.tx != ANTENNA_SW_DIVERSITY)
+	    rt2x00dev->default_ant.tx == ANTENNA_SW_DIVERSITY)
 		rt2x00dev->link.ant.flags |= ANTENNA_TX_DIVERSITY;
 
 	if (!(rt2x00dev->link.ant.flags & ANTENNA_RX_DIVERSITY) &&



--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
2.6.25-rc2 regression in rt61pci wireless driver, Chris Clayton, (Sat Feb 16, 5:06 am)
Re: 2.6.25-rc2 regression in rt61pci wireless driver, Ivo van Doorn, (Mon Feb 18, 11:11 am)
Re: 2.6.25-rc2 regression in rt61pci wireless driver, Ivo van Doorn, (Mon Feb 18, 11:16 am)
Re: 2.6.25-rc2 regression in rt61pci wireless driver, Chris Clayton, (Mon Feb 18, 3:51 pm)
Re: 2.6.25-rc2 regression in rt61pci wireless driver, Ivo van Doorn, (Tue Feb 19, 2:26 am)
Re: 2.6.25-rc2 regression in rt61pci wireless driver, Chris Clayton, (Tue Feb 19, 12:00 pm)
Re: 2.6.25-rc2 regression in rt61pci wireless driver, Ivo van Doorn, (Tue Feb 19, 12:46 pm)
Re: 2.6.25-rc2 regression in rt61pci wireless driver, Chris Clayton, (Tue Feb 19, 1:44 pm)
Re: 2.6.25-rc2 regression in rt61pci wireless driver, Ivo van Doorn, (Tue Feb 19, 2:03 pm)
Re: 2.6.25-rc2 regression in rt61pci wireless driver, Chris Clayton, (Fri Feb 22, 8:46 am)
Re: 2.6.25-rc2 regression in rt61pci wireless driver, Ivo van Doorn, (Fri Feb 22, 12:47 pm)
Re: 2.6.25-rc2 regression in rt61pci wireless driver, Chris Clayton, (Mon Feb 25, 2:04 pm)
Re: 2.6.25-rc2 regression in rt61pci wireless driver, Ivo Van Doorn, (Mon Feb 25, 3:09 pm)
Re: 2.6.25-rc2 regression in rt61pci wireless driver, Chris Clayton, (Tue Feb 26, 12:11 pm)
Re: 2.6.25-rc2 regression in rt61pci wireless driver, John W. Linville, (Tue Feb 26, 12:48 pm)
Re: 2.6.25-rc2 regression in rt61pci wireless driver, Ivo Van Doorn, (Tue Feb 26, 1:30 pm)
Re: 2.6.25-rc2 regression in rt61pci wireless driver, Chris Clayton, (Tue Feb 26, 2:13 pm)
Re: 2.6.25-rc2 regression in rt61pci wireless driver, Stefano Brivio, (Tue Feb 26, 2:38 pm)
Re: 2.6.25-rc2 regression in rt61pci wireless driver, Stefano Brivio, (Tue Feb 26, 2:44 pm)
Re: 2.6.25-rc2 regression in rt61pci wireless driver, Chris Clayton, (Tue Feb 26, 3:36 pm)
Re: 2.6.25-rc2 regression in rt61pci wireless driver, Stefano Brivio, (Wed Feb 27, 12:26 am)
Re: 2.6.25-rc2 regression in rt61pci wireless driver, John W. Linville, (Wed Feb 27, 8:51 am)
Re: 2.6.25-rc2 regression in rt61pci wireless driver, John W. Linville, (Wed Feb 27, 10:25 am)
Re: 2.6.25-rc2 regression in rt61pci wireless driver, Chris Clayton, (Wed Feb 27, 10:45 am)
Re: 2.6.25-rc2 regression in rt61pci wireless driver, Stefano Brivio, (Sun Mar 2, 3:33 am)
Re: 2.6.25-rc2 regression in rt61pci wireless driver, Chris Clayton, (Sun Mar 2, 8:11 am)