Home » Mailing list archives » linux-kernel » 2008 » October » 2

Re: [PATCH 5/5 ver2] debug: BUILD_BUG_ON: error on non-const expressions

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Rusty Russell
Subject: Re: [PATCH 5/5 ver2] debug: BUILD_BUG_ON: error on non-const expressions
Date: Wednesday, October 1, 2008 - 10:35 pm

On Wednesday 03 September 2008 01:57:31 Boaz Harrosh wrote:

Why did you hate the void cast again?  Simplest should 
be "(void)BUILD_BUG_ON_ZERO(e)".  But if not, it seems to me that it's 
cleaner to do:

#define BUILD_BUG_ON(e) \
	do { } while(BUILD_BUG_ON_ZERO(e))

No chance of the compiler emitting unused vars.

Cheers,
Rusty.

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCHSET 0/5] BUILD_BUG_ON: error on none-const expressions, Boaz Harrosh, (Mon Sep 1, 6:00 am)
[PATCH] debug, x86: move BUILD_BUG_ON() ARRAY_SIZE and __F ..., Boaz Harrosh, (Mon Sep 1, 6:07 am)
[PATCH 2/5] net/niu: Fix none-const BUILD_BUG_ON usage, Boaz Harrosh, (Mon Sep 1, 6:11 am)
[PATCH 3/5] virtio: Fix none-const BUILD_BUG_ON usage, Boaz Harrosh, (Mon Sep 1, 6:13 am)
[PATCH 4/5] rt2x00: Compiler warning unmasked by fix of BU ..., Boaz Harrosh, (Mon Sep 1, 6:21 am)
Re: [PATCH 4/5] rt2x00: Compiler warning unmasked by fix o ..., Ivo Van Doorn, (Mon Sep 1, 6:27 am)
Re: [PATCH 4/5] rt2x00: Compiler warning unmasked by fix o ..., Benny Halevy, (Mon Sep 1, 6:27 am)
[PATCH 5/5] debug: BUILD_BUG_ON: error on non-const expres ..., Boaz Harrosh, (Mon Sep 1, 6:28 am)
[PATCH 4/5 ver2] rt2x00: Compiler warning unmasked by fix ..., Boaz Harrosh, (Mon Sep 1, 6:44 am)
Re: [PATCH 5/5] debug: BUILD_BUG_ON: error on non-const e ..., Jan Beulich, (Mon Sep 1, 6:55 am)
Re: [PATCH 4/5 ver2] rt2x00: Compiler warning unmasked by ..., Ivo Van Doorn, (Mon Sep 1, 7:01 am)
Re: [PATCH 5/5] debug: BUILD_BUG_ON: error on non-const e ..., Boaz Harrosh, (Mon Sep 1, 7:21 am)
Re: [PATCH 5/5] debug: BUILD_BUG_ON: error on non-const ..., Jan Beulich, (Mon Sep 1, 7:36 am)
Re: [PATCH 5/5] debug: BUILD_BUG_ON: error on non-const ..., Boaz Harrosh, (Mon Sep 1, 8:00 am)
Re: [PATCH 4/5 ver2] rt2x00: Compiler warning unmasked by ..., Boaz Harrosh, (Mon Sep 1, 8:17 am)
Re: [PATCH 5/5] debug: BUILD_BUG_ON: error on non-const ..., Jan Beulich, (Mon Sep 1, 8:29 am)
Re: [PATCH 4/5 ver2] rt2x00: Compiler warning unmasked by ..., Ivo van Doorn, (Mon Sep 1, 9:34 am)
Re: [PATCH 5/5] debug: BUILD_BUG_ON: error on non-const ..., Boaz Harrosh, (Mon Sep 1, 9:41 am)
Re: [PATCH 5/5] debug: BUILD_BUG_ON: error on non-const e ..., Jan Beulich, (Tue Sep 2, 12:47 am)
Re: [PATCH 4/5 ver2] rt2x00: Compiler warning unmasked by ..., Boaz Harrosh, (Tue Sep 2, 7:20 am)
Re: [PATCH 4/5 ver2] rt2x00: Compiler warning unmasked by ..., Ivo van Doorn, (Tue Sep 2, 7:27 am)
Re: [PATCH 5/5] debug: BUILD_BUG_ON: error on non-const e ..., Boaz Harrosh, (Tue Sep 2, 8:19 am)
[PATCH 3/5 ver2] virtio: Fix non-const BUILD_BUG_ON usage, Boaz Harrosh, (Tue Sep 2, 8:53 am)
[PATCH 4/5 ver2] rt2x00: Compiler warning unmasked by fix ..., Boaz Harrosh, (Tue Sep 2, 8:55 am)
[PATCH 5/5 ver2] debug: BUILD_BUG_ON: error on non-const e ..., Boaz Harrosh, (Tue Sep 2, 8:57 am)
Re: [PATCH 5/5 ver2] debug: BUILD_BUG_ON: error on non-con ..., Boaz Harrosh, (Tue Sep 2, 9:06 am)
Re: [PATCH 5/5 ver3] debug: BUILD_BUG_ON: error on non-con ..., Boaz Harrosh, (Tue Sep 2, 9:07 am)
Re: [PATCH 5/5 ver2] debug: BUILD_BUG_ON: error on non-con ..., Jan Beulich, (Tue Sep 2, 9:11 am)
Re: [PATCH 5/5 ver2] debug: BUILD_BUG_ON: error on non-con ..., Boaz Harrosh, (Wed Sep 3, 1:57 am)
Re: [PATCH 5/5 ver2] debug: BUILD_BUG_ON: error on non-con ..., Jan Beulich, (Wed Sep 3, 3:19 am)
Re: [PATCH 5/5 ver2] debug: BUILD_BUG_ON: error on non-con ..., Boaz Harrosh, (Wed Sep 3, 3:52 am)
Re: [PATCHSET 0/5] BUILD_BUG_ON: error on none-const expre ..., Ingo Molnar, (Sat Sep 6, 9:01 am)
Re: [PATCH 5/5 ver2] debug: BUILD_BUG_ON: error on non-con ..., Rusty Russell, (Wed Oct 1, 10:35 pm)
Re: [PATCH 5/5 ver2] debug: BUILD_BUG_ON: error on non-con ..., Boaz Harrosh, (Sun Oct 5, 2:34 am)